avoid voice_count becomming negative #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bug around fluid_voice_off(), fixes issue #151
ensonic
reviewed
Jul 3, 2017
| needs to be damped even if pedals (sustain sostenuto) are depressed. | ||
| See fluid_synth_damp_voices_LOCAL(), fluid_synth_damp_voices_by_sostenuto_LOCAL, | ||
| fluid_voice_noteoff(), fluid_synth_stop_LOCAL(). | ||
| */ |
There was a problem hiding this comment.
why are you remove this comment. Maybe move to the c file?
There was a problem hiding this comment.
A more up to date comment for this function is present at
fluidsynth/fluidsynth/src/synth/fluid_voice.c
Line 1186 in 80b46c6
Also, I'm afraid you are the only available reviewer currently, as the others are inactive (did you got my mail?).
ensonic
reviewed
Jul 3, 2017
|
Defer this, as jjc wants to come up with a better solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bug around fluid_voice_off(), fixes issue #151